Regex editorial improvements, and permit "." #1470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistently "quote" examples.
Split complemented simple and range class examples.
Improve "(" .. ")" grouping example.
notEthan
reviewed
Jan 31, 2024
|
We've discussed this before, and I think it may be worth bringing it up again. IETF has now published https://datatracker.ietf.org/doc/rfc9485/ to support interoperable regex in JSON Path. It may be wise to reconsider this in place of ECMA. Doing so would mean being able to remove all of these restrictions. |
|
@gregsdennis I feel like I'm inclined to agree with this person's opinion that iregexp is not a good fit for JSON Schema - though I have not kept up with any changes since 2022 that may have changed that situation. |
|
Yeah, I hear you. But finding interoperable regex support has been a thorn in our side for a long time. It really has no bearing on this PR, though. |
gregsdennis
reviewed
Feb 19, 2024
|
I've added 3 commits addressing various review feedback above. |
gregsdennis
reviewed
Feb 22, 2024
notEthan
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "." to the permitted simple atoms, for issue #1469.
Consistently format the regex examples.