Skip to content

make format validate by default #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 21, 2024
Merged

make format validate by default #1553

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9b19a36
make format validate by default
gregsdennis Oct 28, 2024
3de61f2
add ADR for change in format behavior
gregsdennis Nov 2, 2024
e13e156
removed permissive language from format requirements
gregsdennis Nov 7, 2024
81d64ba
Update adr/2024-11-2-assertion-format.md
gregsdennis Nov 13, 2024
16a7515
Update specs/jsonschema-validation.md
gregsdennis Nov 13, 2024
1b0e4bb
Update specs/jsonschema-validation.md
gregsdennis Nov 13, 2024
ff8f074
update adr with results of vote
gregsdennis Nov 13, 2024
8e33d21
Update specs/jsonschema-validation.md
gregsdennis Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update specs/jsonschema-validation.md 
Co-authored-by: Jason Desrosiers <[email protected]>
  • Loading branch information
@gregsdennis @jdesrosiers
gregsdennis and jdesrosiers authored Nov 13, 2024
commit 8e33d21e95c05505fe1d1c77b6593fc43a32a226
4 changes: 2 additions & 2 deletions specs/jsonschema-validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,8 @@ be explicitly defined to always pass if the number is not an integer, which
produces essentially the same behavior as only applying to integers.

Implementations SHOULD provide assertion behavior for the format values defined
by this document[^2] and MUST refuse to process any schema which contains an
unsupported format value.
by this document[^2] and MUST refuse to process any schema which contains a
format value it doesn't support.

[^2]: Assertion behavior is called out very explicitly because it is a departure
from previous iterations of this specification. Previously, `format` was an
Expand Down
Loading