Skip to content

[954] Fix $recursiveAnchor in schema to match spec #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ssilverman
Copy link
Member

@ssilverman ssilverman commented Jun 11, 2020

The spec allows values of false. This fixes the schema to match the spec.

Closes #954

@ssilverman
Copy link
Member Author

See https://json-schema.org/draft/2019-09/json-schema-core.html#rfc.section.8.2.4.2.2:

If this keyword is set to false, the base URI is unchanged.

Also, the spec doesn't require the value to be true.

The spec allows values of false. This fixes the schema to match the spec.
@ssilverman ssilverman force-pushed the fix-schema-recursiveAnchor branch from 222bce0 to 568e20f Compare August 1, 2020 16:34
@ssilverman ssilverman changed the title Fix $recursiveAnchor in schema to match spec [954] Fix $recursiveAnchor in schema to match spec Aug 1, 2020
@Relequestual
Copy link
Member

Thanks!
Could you also update the 2019-09 meta schema please?
Once done, I'll merge.

@karenetheridge
Copy link
Member

Could you also update the 2019-09 meta schema please?

what update is needed? $recursiveAnchor isn't defined in the main meta-schema document.

@Relequestual
Copy link
Member

What appears on the website for fetching, the schemas for previous versions are included via git submodule.
This can be eased if the branch on here gets updated with the fix too.
This also applies for #900 but I just didn't remember.

@Relequestual
Copy link
Member

I guess what we actually need is a second PR, because this one can be merged.

@karenetheridge
Copy link
Member

PR created in #968.

@Relequestual Relequestual merged commit ed501eb into json-schema-org:master Aug 15, 2020
@ssilverman ssilverman deleted the fix-schema-recursiveAnchor branch August 15, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec disagrees with meta-schema for $recursiveAnchor
3 participants