feature: add name length check for fedresourcequota

[likakuli]

Signed-off-by: likakuli [email protected]

What type of PR is this?
/kind feature

What this PR does / why we need it:

FedResourceQuota is a user-facing resource and its name is used in work's label. So the length should be no more than 63 characters like other resource. e.g. PropagationPolicy

Which issue(s) this PR fixes:
Fixes #
Part of #6350

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-webhook`: The length of FederatedResourceQuota now has been restricted to no more than 63 chars.

[XiShanYongYe-Chang]

I think it makes sense to add this validation. However, it may be not a bug fix but only a verification enhancement.

[likakuli]

I think it makes sense to add this validation. However, it may be not a bug fix but only a verification enhancement.

OK，let me update the kind.

[XiShanYongYe-Chang]

This failing e2e case will be fixed by #2177

[RainbowMango]

FedResourceQuota is a user-facing resource and its name is used in work's label.

I'm afraid this is the wrong decision that directly takes name as the label.
We already have lessons learned about that. We should use the hash value, just like what we did for ResourceBinding.

By the way, restricting the name length definitely a cheaper way, but we should avoid doing that as we don't know exactly the use case and should not make the assumption that the name length never exceeds 63.

[RainbowMango]

Hi @likakuli Long time no see, hope you are doing well.
As I mentioned earlier, using resource names as labels is not a recommended practice. However, this approach was once widely used in Karmada. Fortunately, we have fixed most of these issues, such as replacing it with the UUID of PropagationPolicy. Unfortunately, FederatedResourceQuota still is an exception.

Currently, we are enhancing the FederatedResourceQuota, see #6350, For now, I think we can adopt this cheaper solution to prevent people from doing wrong and fix it later.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.34%. Comparing base (fc44746) to head (9dde2b0).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2168      +/-   ##
==========================================
- Coverage   49.34%   49.34%   -0.01%     
==========================================
  Files         678      678              
  Lines       55050    55061      +11     
==========================================
+ Hits        27167    27168       +1     
- Misses      26115    26124       +9     
- Partials     1768     1769       +1     

Flag	Coverage Δ
unittests	49.34% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[RainbowMango]

/assign

[RainbowMango]

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment