-
Notifications
You must be signed in to change notification settings - Fork 947
Add feature gates support to karmada-webhook config (Helm Chart) #6384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: wei-chenglai <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6384 +/- ##
==========================================
- Coverage 49.35% 49.35% -0.01%
==========================================
Files 685 685
Lines 55687 55687
==========================================
- Hits 27484 27483 -1
Misses 26404 26404
- Partials 1799 1800 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
I bet you have tested it :)
{{- /* | ||
Generate the --feature-gates command line argument for karmada-webhook. | ||
Iterates over .Values.webhook.featureGates and constructs a comma-separated key=value list. | ||
If any feature gates are set, outputs: --feature-gates=Foo=true,Bar=false | ||
If none are set, outputs nothing. | ||
*/ -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I like the comments~
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds feature gates support to the
karmada-webhook
Helm Chart configuration. Users can now configure feature gates for the webhook component via thewebhook.featureGates
field invalues.yaml
, similar to other components like controllerManager and schedulerEstimator. This provides a consistent and flexible way to enable or disable webhook features across all installation modes.Which issue(s) this PR fixes:
Part of #6350
Special notes for your reviewer:
Does this PR introduce a user-facing change?: