Skip to content

Add feature gates support to karmada-webhook config (Helm Chart) #6384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025

Conversation

seanlaii
Copy link
Contributor

@seanlaii seanlaii commented May 17, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds feature gates support to the karmada-webhook Helm Chart configuration. Users can now configure feature gates for the webhook component via the webhook.featureGates field in values.yaml, similar to other components like controllerManager and schedulerEstimator. This provides a consistent and flexible way to enable or disable webhook features across all installation modes.

Which issue(s) this PR fixes:
Part of #6350

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`Helm Chart`: Users can now configure feature gates for karmada-webhook via the Helm Chart using the `webhook.featureGates` field in values.yaml.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 17, 2025
@karmada-bot karmada-bot requested review from a7i and jrkeen May 17, 2025 00:52
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.35%. Comparing base (850c4fb) to head (8683729).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6384      +/-   ##
==========================================
- Coverage   49.35%   49.35%   -0.01%     
==========================================
  Files         685      685              
  Lines       55687    55687              
==========================================
- Hits        27484    27483       -1     
  Misses      26404    26404              
- Partials     1799     1800       +1     
Flag Coverage Δ
unittests 49.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I bet you have tested it :)

Comment on lines +571 to +576
{{- /*
Generate the --feature-gates command line argument for karmada-webhook.
Iterates over .Values.webhook.featureGates and constructs a comma-separated key=value list.
If any feature gates are set, outputs: --feature-gates=Foo=true,Bar=false
If none are set, outputs nothing.
*/ -}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
I like the comments~

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2025
@karmada-bot karmada-bot merged commit 1801dca into karmada-io:master May 17, 2025
24 checks passed
@seanlaii seanlaii deleted the chart-feature branch May 17, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants