-
Notifications
You must be signed in to change notification settings - Fork 966
feat: allow tagging in incident comments #4669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@rohitdash08 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before reviewing this PR - can you add e2e test for this? so I'll be able to reproduce?
@shahargl, I have added the e2e test |
Hey! |
Hey @skynetigor, I have made the required changes right now we are using react quill as you suggested. |
keep-ui/app/(keep)/incidents/[id]/activity/ui/MentionsInput.tsx
Outdated
Show resolved
Hide resolved
@rohitdash08 could you please record a video how it works and attach to the PR? |
@rohitdash08
![]() ![]() Could you please take a look? |
This reverts commit 729b188.
hey @rohitdash08! Any update on @skynetigor comments? |
Hey @Kiryous, yes currently I'm working on it. |
/claim #2187
Fixes #2187
Closes #
📑 Description
✅ Checks
ℹ Additional Information