Skip to content

feat: allow tagging in incident comments #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rohitdash08
Copy link

@rohitdash08 rohitdash08 commented May 1, 2025

/claim #2187
Fixes #2187

Closes #

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Copy link

vercel bot commented May 1, 2025

@rohitdash08 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 1, 2025
@CLAassistant
Copy link

CLAassistant commented May 1, 2025

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added API API related issues Incident labels May 1, 2025
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before reviewing this PR - can you add e2e test for this? so I'll be able to reproduce?

@rohitdash08
Copy link
Author

@shahargl, I have added the e2e test
Please let me know if anything else is required from my end.

@rohitdash08 rohitdash08 changed the title allow tagging in incident comments Enhancement: allow tagging in incident comments May 3, 2025
@rohitdash08 rohitdash08 changed the title Enhancement: allow tagging in incident comments feat: allow tagging in incident comments May 3, 2025
@skynetigor
Copy link
Contributor

Hey!
Quick question — since we’re already using ReactQuill, could we integrate quill-mention to handle mentions instead of building a custom input from scratch?
It seems like a lighter approach, given that Quill is already part of our stack.

@rohitdash08
Copy link
Author

Hey @skynetigor, I have made the required changes right now we are using react quill as you suggested.
Please let me know if anything else is required from my end.

@skynetigor
Copy link
Contributor

@rohitdash08 could you please record a video how it works and attach to the PR?

@skynetigor
Copy link
Contributor

@rohitdash08
I've just tried to use the feature and I see the following issues:

  • It looks like it does not render text as it has to
image - When I refresh the page being on activity tab, the input is broken: image - Looks like mentioning does not work. When I hit @ - the mentioning dropdown does not show up.

Could you please take a look?

@skynetigor
Copy link
Contributor

Another critical issue is that the BE fails to migrate MySql DB with this error (I did merge between two heads being in the PR right now):
image

This reverts commit 729b188.
@Kiryous
Copy link
Contributor

Kiryous commented May 15, 2025

hey @rohitdash08! Any update on @skynetigor comments?

@rohitdash08
Copy link
Author

Hey @Kiryous, yes currently I'm working on it.
It will be resolved by 05/17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related issues 🙋 Bounty claim Incident size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🔨 Enhancement]: Allow tagging in Incident comment
5 participants