-
Notifications
You must be signed in to change notification settings - Fork 965
feat: Add Flux CD provider for service topology and alert integration #4721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Kunal-Darekar is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
@talboren Could you please review this Flux CD provider implementation when you have a moment? Thanks! |
The implementation looks good! but there are still failing tests, could you please fix them? I think @Kiryous and @Matvey-Kuk can help you with the test-workflow-examples and test-docs, respectively, if you need help. |
…xCD workflow example
Hey @talboren , Thanks for the feedback! I've fixed the failing tests — please have a look when you get a chance. Let me know if anything else needs adjusting. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Kunal-Darekar looks like it is still failing.. |
981e17f
to
80b6252
Compare
a4b2672
to
940c53d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask you to exclude fixes for docs tests and general tests to the separate PR?
hey @Kunal-Darekar! Thank you so much for the thoughtful contribution! Left a few comments, let's address them and merge 🧡 |
e882703
to
74fed44
Compare
Co-authored-by: Kirill Chernakov <[email protected]> Signed-off-by: Kunal Darekar <[email protected]>
Co-authored-by: Kirill Chernakov <[email protected]> Signed-off-by: Kunal Darekar <[email protected]>
1. Add UTF-8 encoding to file operations in docs_render_provider_snippets.py 2. Normalize path separators for cross-platform compatibility 3. Improve test reliability by increasing sleep time and max attempts 4. Add detailed comments explaining the changes These changes address the feedback from PR keephq#4721 review.
This PR adds a new provider for Flux CD, similar to the existing ArgoCD provider. Flux CD is a GitOps tool for Kubernetes that provides continuous delivery through automated deployment, monitoring, and management of applications.
Features Implemented
Topology Integration
Alert Integration
Authentication Options
Provider Metadata
Implementation Details
Documentation
Testing
/fixes #4632
/claim #4632