fix: Add support for nested fields in dashboard widgets #4795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukeod is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
size:M
lukeod
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4795 +/- ##
==========================================
- Coverage 30.97% 30.80% -0.17%
==========================================
Files 93 93
Lines 10855 10949 +94
==========================================
+ Hits 3362 3373 +11
- Misses 7493 7576 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skynetigor
reviewed
May 17, 2025
keep-ui/shared/lib/object-utils.ts
Outdated
| * @param path The dot-notation path to the desired property (e.g., 'annotations.summary') | ||
| * @returns The value at the specified path, or undefined if the path doesn't exist | ||
| */ | ||
| export function getNestedValue(obj: any, path: string): any { |
There was a problem hiding this comment.
Great job!
Just maybe one comment from me to add unit-test for this function 🙏
dosubot
bot
added
size:L
dosubot
bot
added
size:XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4794 - Adds support for nested fields in dashboard widgets