Skip to content

fix: Add support to customize ignorable statuses for maintenance windows #4817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VladimirFilonov
Copy link
Contributor

@VladimirFilonov VladimirFilonov commented May 16, 2025

Closes #4809

📑 Description

image

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview May 16, 2025 0:47am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. API API related issues labels May 16, 2025
Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.79%. Comparing base (7d126de) to head (3dbd09c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/bl/maintenance_windows_bl.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4817       +/-   ##
===========================================
- Coverage   46.14%   30.79%   -15.36%     
===========================================
  Files         165       93       -72     
  Lines       17428    11000     -6428     
===========================================
- Hits         8043     3387     -4656     
+ Misses       9385     7613     -1772     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related issues size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Alert Statuses to Ignore should be configurable
1 participant