Skip to content

async vs. return a promise #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

async vs. return a promise #6

wants to merge 1 commit into from

Conversation

nkabbara
Copy link

@nkabbara nkabbara commented Aug 5, 2020

Maybe this is clearer since it's in the same vain of the other changes (making functions async in the tests).

@nkabbara
async vs. return a promise
99053f9 
Maybe this is clearer since it's in the same vain of the other changes (making functions async in the tests).
kentcdodds
kentcdodds reviewed Aug 5, 2020
View reviewed changes
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is another way to do it, but I prefer the Promise. Thanks though!

@kentcdodds kentcdodds closed this Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkabbara @kentcdodds