Speeding the tests for DistilBert #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
requested changes
Mar 20, 2023
| (self.batch_size, self.model.max_sequence_length), dtype="int32" | ||
| ), | ||
| "token_ids": tf.ones((2, 5), dtype="int32"), | ||
| "segment_ids": tf.ones((2, 5), dtype="int32"), |
There was a problem hiding this comment.
distilbert does not take in "segment_ids":. Pleas make sure to run all the tests you are modifying, ideally locally before creating a PR.
pytest keras_nlp/models/distil_bert will run the basic tests, see our contributor guide for more details.
mattdangerw
reviewed
Mar 28, 2023
| (self.batch_size, self.model.max_sequence_length), dtype="int32" | ||
| ), | ||
| "token_ids": tf.ones((2, 5), dtype="int32"), | ||
| "mask_positions": tf.ones((2, 5), dtype="int32"), |
There was a problem hiding this comment.
mask positions is not an input to the backbone I believe
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #866
@mattdangerw @chenmoneygithub
Before 235.24
After 106.96s