Skip to content

Speeding the tests for Albert #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2023
Merged

Speeding the tests for Albert #873

merged 2 commits into from
Mar 30, 2023

Conversation

soma2000-lang
Copy link
Contributor

@soma2000-lang soma2000-lang commented Mar 18, 2023 •
edited
Loading

Partially address #866
@mattdangerw @chenmoneygithub
Before 205.57s
After 95.58s

@soma2000-lang soma2000-lang changed the title Adding Speeding the tests for Albert Mar 18, 2023
mattdangerw
mattdangerw requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of legitimate test failures here! Please try to run test locally before creating a PR. You can specify a path to just run tests for a specific directory of test file, as described in our contributor guide.

chenmoneygithub
chenmoneygithub reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The PR looks good to me, could you post the time cost before/after this PR? You can run this command on head and this branch separately:

pytest keras_nlp/models/albert

Thanks!

@soma2000-lang soma2000-lang requested review from chenmoneygithub and removed request for mattdangerw March 28, 2023 00:54
chenmoneygithub
chenmoneygithub approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chenmoneygithub chenmoneygithub merged commit 794c4b1 into keras-team:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw requested changes

@chenmoneygithub chenmoneygithub chenmoneygithub approved these changes

Assignees

@chenmoneygithub chenmoneygithub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soma2000-lang @mattdangerw @chenmoneygithub