Skip to content

Implement kaiser function in keras.ops #21303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025
Merged

Conversation

shashaka
Copy link
Contributor

Adds keras.ops.kaiser, which computes the Kaiser window. Supported across NumPy, TensorFlow, PyTorch, and JAX backends, but not supported on OpenVINO.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.58%. Comparing base (dfaca0e) to head (180fd2d).

Files with missing lines Patch % Lines
keras/src/ops/numpy.py 84.61% 1 Missing and 1 partial ⚠️
keras/api/_tf_keras/keras/ops/__init__.py 0.00% 1 Missing ⚠️
keras/api/_tf_keras/keras/ops/numpy/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21303   +/-   ##
=======================================
  Coverage   82.57%   82.58%           
=======================================
  Files         564      564           
  Lines       54677    54707   +30     
  Branches     8500     8501    +1     
=======================================
+ Hits        45152    45178   +26     
- Misses       7435     7438    +3     
- Partials     2090     2091    +1     
Flag Coverage Δ
keras 82.39% <86.66%> (+<0.01%) ⬆️
keras-jax 63.61% <60.00%> (-0.01%) ⬇️
keras-numpy 58.74% <63.33%> (+<0.01%) ⬆️
keras-openvino 33.04% <36.66%> (+<0.01%) ⬆️
keras-tensorflow 64.02% <60.00%> (-0.01%) ⬇️
keras-torch 63.68% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you! LGTM

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 20, 2025
@fchollet fchollet merged commit a9ff3a7 into keras-team:master May 20, 2025
11 checks passed
@shashaka shashaka deleted the kaiser branch May 20, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Ready to be merged into the codebase size:M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants