Skip to content

Implement PolicyService #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Implement PolicyService #61

merged 2 commits into from
May 14, 2025

Conversation

nfreq
Copy link
Contributor

@nfreq nfreq commented May 14, 2025

PolicyService is used to do the following:

Start Policy (kinfer filename, episode length, action scale)
Stop Policy
Get Policy State/Status

Currently tested and being used in kos-zbot

@nfreq nfreq requested review from codekansas and WT-MM as code owners May 14, 2025 17:16
Copy link
Member

@codekansas codekansas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see - so the idea is that the policy is stored locally under some uuid, and we can trigger it to start or stop? i think this makes sense, we should integrate this with the kscale api and pull and push models from there

@nfreq
Copy link
Contributor Author

nfreq commented May 14, 2025

yes, in the current state, the uuid simply represents a local kinfer file. I like the idea of having models that can be pulled for the api!

@nfreq
Copy link
Contributor Author

nfreq commented May 14, 2025

Can we merge this as it stands and plan for full kscale api integration in the near future?

@CLAassistant
Copy link

CLAassistant commented May 14, 2025

CLA assistant check
All committers have signed the CLA.

@nfreq nfreq merged commit 4a61e69 into master May 14, 2025
2 checks passed
@nfreq nfreq deleted the policy-service branch May 14, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants