-
Notifications
You must be signed in to change notification settings - Fork 340
feat: mvp controller #2036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: mvp controller #2036
Conversation
Signed-off-by: Bence Csati <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new MVP controller for AxoSyslog by introducing new types, resources, and controller logic for managing AxoSyslog deployments. Key changes include:
- Renaming and updating default image constants and their usage in API types.
- Adding new resource types (StatefulSet, Service, RBAC) for AxoSyslog.
- Updating the controller to leverage a generic reconciler with improved error wrapping and additional resource reconciliation loops.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
pkg/sdk/logging/api/v1beta1/syslogng_types.go | Renaming default image constants and updating defaults logic. |
pkg/sdk/logging/api/v1beta1/axosyslog_types.go | Adding new image fields and defaults for AxoSyslogSpec. |
pkg/resources/reconciler.go | Introducing new resource function types. |
pkg/resources/axosyslog/statefulset.go | New StatefulSet resource with config generation for reloader. |
pkg/resources/axosyslog/service.go | New Service, HeadlessService, and placeholders for metrics. |
pkg/resources/axosyslog/rbac.go | New RBAC resources for AxoSyslog. |
controllers/logging/axosyslog_controller.go | Updated controller using generic reconciler and improved errors. |
b9a38b5
to
d010976
Compare
d010976
to
cac4460
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces MVP support for the AxoSyslog controller by adding new image specifications, updating defaulting logic, and adding new resource builders for statefulset and service management. Key changes include:
- Adding new "Image" and "ConfigReloadImage" fields to the AxoSyslog CRD and corresponding deepcopy and defaulting logic.
- Introducing additional resource types and updated reconciliation logic in the controller.
- Updating CRD schemas and documentation in both the base and chart configurations.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
pkg/sdk/logging/api/v1beta1/zz_generated.deepcopy.go | Adds deepcopy support for new image fields. |
pkg/sdk/logging/api/v1beta1/syslogng_types.go | Updates default image constants with new naming. |
pkg/sdk/logging/api/v1beta1/axosyslog_types.go | Adds new fields and defaulting for image specifications. |
pkg/resources/reconciler.go | Introduces new resource builder types. |
pkg/resources/axosyslog/statefulset.go | Implements statefulset generation, including a JSON config reloader. |
pkg/resources/axosyslog/service.go | Adds functions for service creation and stubs for metrics services. |
docs/configuration/crds/v1beta1/axosyslog_types.md | Updates documentation for new image fields. |
controllers/logging/axosyslog_controller.go | Refactors controller reconciliation with enhanced error handling and resource reference setting. |
config/crd/bases/logging.banzaicloud.io_axosyslogs.yaml | Updates CRD with new image properties. |
charts/logging-operator/crds/logging.banzaicloud.io_axosyslogs.yaml | Mirrors CRD changes in chart definitions. |
charts/logging-operator/charts/logging-operator-crds/templates/logging.banzaicloud.io_axosyslogs.yaml | Updates CRD template for new image fields. |
Signed-off-by: Bence Csati <[email protected]>
cac4460
to
dfd3266
Compare
Signed-off-by: Bence Csati <[email protected]>
No description provided.