NEG Controller: fix the multinet NEG location to prevent constant NEG detach calls #2903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lculator for Multi Networking service, use the MN network as as the NEG subnet instead of the subnet of the node. This is to make sure the location from the calculator matches the 'current' state calculated before and also so that the location actually matches the actual subnet the NEG will reside in.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/M
|
Thanks @mmamczur. This .... |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, mmamczur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEG Controller, when generating desired endpoints in the endpoints calculator for Multi Networking service, use the MN network as as the NEG subnet instead of the subnet of the node.
This is to make sure the location from the calculator matches the 'current' state calculated before and also so that the location actually matches the actual subnet the NEG will reside in.
Without this change the NEG controller calculation will be different for current state and for desired, so the controller will think it has to detach and attach endpoints. This will result in the controller issuing constant detach calls, exhausting the quota in the project for the NEG API.