Fix issue #3: unidiomatic-typecheck only checks left-hand side #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #3.
The PR has successfully addressed the issue by modifying the comparison logic in the comparison_checker.py file. The changes now properly handle both cases of type comparison:
type(x) == Y
andY == type(x)
. The implementation:The changes ensure that the unidiomatic-typecheck checker will now catch both comparison patterns consistently, with proper error messages, without introducing false positives. The test cases and file structure changes were also cleaned up to support this functionality. The issue is fully resolved as the code now meets all requirements from the original bug report.