Fix issue #17: Dynamic color mapping for "fail-on" messages/categories in ColorizedTextReporter #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in ColorizedTextReporter
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit d03ac55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #17.
The PR has successfully addressed the issue by implementing dynamic message coloring for custom
fail-onconfigurations. The key changes include:fail_on_symbolslist to store custom fail-on configurations_get_decorationmethod to check if a message is infail_on_symbolsand apply special styling (red, bold, inverse) if foundfail_on_symbolswhen the module changes viaon_set_current_moduleThese changes allow the colorizer to:
The implementation provides the requested functionality without requiring external verification, as the core logic for dynamic styling is now properly implemented in the text reporter. The test files included in the PR demonstrate the system can handle various module configurations while maintaining the new coloring behavior.