Fix issue #17: Dynamic color mapping for "fail-on" messages/categories in ColorizedTextReporter #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #17.
The issue has been successfully resolved. The PR made the following key changes:
Modified the ColorizedTextReporter to accept a linter instance in its constructor and dynamically update color mapping based on the linter's fail_on_symbols attribute.
Added a new method _update_color_mapping that applies the same styling (red + bold) to custom fail-on symbols as used for error messages.
Updated the reporter registration to pass the linter instance to the ColorizedTextReporter.
These changes ensure that:
The solution directly addresses the original issue by making custom fail-on messages stand out in CI logs, eliminating the need for manual workarounds. The implementation provides the dynamic behavior requested in the original issue description.