Skip to content

Commit 2d59de7

Browse files
Merge pull request ryanmcdermott#97 from vsemozhetbyt/no-shadow
fix variable shadowing
2 parents bfa3eb3 + 25791b0 commit 2d59de7

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

README.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ const menuConfig = {
229229
cancellable: true
230230
}
231231

232-
function createMenu(menuConfig) {
232+
function createMenu(config) {
233233
// ...
234234
}
235235

@@ -1702,14 +1702,14 @@ Promises are a built-in global type. Use them!
17021702

17031703
**Bad:**
17041704
```javascript
1705-
require('request').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin', function(err, response) {
1706-
if (err) {
1707-
console.error(err);
1705+
require('request').get('https://en.wikipedia.org/wiki/Robert_Cecil_Martin', (requestErr, response) => {
1706+
if (requestErr) {
1707+
console.error(requestErr);
17081708
}
17091709
else {
1710-
require('fs').writeFile('article.html', response.body, function(err) {
1711-
if (err) {
1712-
console.error(err);
1710+
require('fs').writeFile('article.html', response.body, (writeErr) => {
1711+
if (writeErr) {
1712+
console.error(writeErr);
17131713
} else {
17141714
console.log('File written');
17151715
}

0 commit comments

Comments
 (0)