Skip to content

[5.4] Add more information to migrations #18220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

gsaqui
Copy link

@gsaqui gsaqui commented Mar 6, 2017

When running a number of migrations it will give information on which migration is currently running and when the migration is finished it will say how many seconds it took to run. laravel/ideas#436

Running: 2014_10_12_000000_create_users_table...Done! (2s)
Running: 2014_10_12_100000_create_password_resets_table...Done! (0s)

@gsaqui
Copy link
Author

gsaqui commented Mar 6, 2017

Do I need to fix the styles? I thought StyleCI dealt with it after the merge was committed.

@sailingdeveloper
Copy link
Contributor

@gsaqui Yes, you do :)

@stefanoruth
Copy link
Contributor

Dont really see the need with migrations but with seeders it could be nice :)

@@ -64,17 +64,12 @@ public function fire()
// Next, we will check to see if a path option has been defined. If it has
// we will use the path relative to the root of this installation folder
// so that migrations may be run for any path within the applications.

Copy link
Contributor

@fernandobandeira fernandobandeira Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this line should be removed...

@taylorotwell
Copy link
Member

No plans to add this for now.

@gsaqui
Copy link
Author

gsaqui commented Mar 6, 2017

@taylorotwell not really sure where the break down of communication happened. I raised this issue laravel/ideas#436 and then asked if this was something that would be accepted on https://larachat.slack.com/messages/internals and assumed that this was something that the community wanted. Where did I go wrong so next time this doesn't happen?

@stefanoruth the reason I wrote this was because I have long running migrations and I'm never sure which one is running at the time and wanted the framework to give me some indication. The current situation is you don't know what is happening until the end when you get an output of the migrations that ran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants