Make model relationship creates filtered by fillable array

[vlakarados]

Currently, when creating instances in a model relationship, attribute $fillable = array(...) of the relationship is ignored. As stated by the comment, it's done so to allow foreign keys to be automatically set. Now it allows us to do this as it fills attributes beforehand with fill() and then sets merged raw attributes filtered by fill() with foreign keys, thus, we may now do things like

$contactData = [
    'type' => 'qwe',
    'value' => 'qwe',
    'foo' => 999
];
$client = Client::find(1);
$client->contacts()->create($contactData);

which is much more clean than

$contactData = [
    'type' => 'qwe',
    'value' => 'qwe',
    'foo' => 999
];

$client = Client::find(1);
$clientContact = ClientContact::create($contactData);
$client->contacts()->save($clientContact);

In the examples above 'foo' database table column does not exist and because of that we get the SQL error if we don't fill().

[bencorlett]

Unless I'm missing something, shouldn't you be able to just call $instance->fill(array_merge($attributes, $foreign));?

[anlutro]

The foreign key will rarely be fillable.

[bencorlett]

Just left you a comment... Also, you will need to make get unit tests passing to get this merged :)

[vlakarados]

@bencorlett I'm currently working on making tests work, I'm not so experienced at them so it may take a while, but will get them working. The point in why didn't I make the fill() call directly is the same why it wasn't implemented before - in most cases you don't want your foreign keys be fillable, if they're not in the $fillable array they won't be set and filtered out by fill(), this way we'll have all the user input filtered and filled and only after that the setRawAttributes() will update the foreign keys.

[vlakarados]

Looks like it passes tests now, I want to mention the tests were made by @anlutro. Big thanks to him.

[cheelahim]

Another point is that $instance->fill($attributes); calls $this->setAttribute($key, $value) which in its turn triggers attribute mutators accordingly. In other words without @vlakarados fix mutators will be ignored while related model creating. I found current situation counterintuitive.

[danharper]

I just wanted to give a quick +1 to this issue as I've just been chasing code around the framework trying to work out why my set mutators weren't firing. It was due to the relation's create method using setRawAttributes instead of fill. It seems very counter-intuitive.

This PR should fix these issues, unless there was another reason that it's always been like this?

[taylorotwell]

Fixed this a tad differently... will be on 4.2.

[danharper]

Awesome, cheers!

[taylorotwell]

I would put it on 4.1 but if people are already working around it I don't want to break their work-arounds on a point release. So 4.2.

[vlakarados]

Thank you! Really great!

[reneweteling]

@taylorotwell great work btw, but what workaround should we use in the meantime?