[12.x] Add App::shouldSyncLocale()
to keep helpers in line with the app locale
#55326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Number helper it is possible to specify the locale. The locale's default however, is always English and doesn't change when the app's locale changes. Carbon however, does do this. This leads to the awkward situation where Carbon returns localized results (where applicable), where Number doesn't.
Carbon's service provider listens for the LocaleUpdated event and updates its locale accordingly. This PR proposes a convience method to the Application class to do the same, as enabling this behaviour by default could be considered as a breaking change. Enabling this behaviour by default may be interesting for the next major version.