Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, currently falsy default values do not function as expected for select inputs.
Consider the following example (included as a test):
I'd expect the highlighted option to be 0, but currently it is 3. This is because 0 is falsy - failing the
if($this->default)
check and resulting in the first option being highlighted by default.My proposed fix for this, is to change the check to
if($this->default !== null)
, allowing the following non-null falsy values to be used as defaults.If this is merged, I'm happy to also look into other inputs that this may affect.