chore: Fix implicit intent handling #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchronizers operate by building up changes using a change set builder. This builder is primed with a server-intent, and then updated as subsequent changes are received. If the initial response to the synchronizer is `xfer-none`, we still need to store this intent. However, the intent code should be updated to show that we are now waiting for pending changes. Otherwise, when those subsequent changes arrive, the code will suggest to upstream behavior that we have no changes to process.
tanderson-ld
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronizers operate by building up changes using a change set builder.
This builder is primed with a server-intent, and then updated as
subsequent changes are received.
If the initial response to the synchronizer is
xfer-none, we stillneed to store this intent. However, the intent code should be updated to
show that we are now waiting for pending changes. Otherwise, when those
subsequent changes arrive, the code will suggest to upstream behavior
that we have no changes to process.