chore: Implement snapshot method on data store #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
force-pushed
the
mk/sdk-1252/improved-ro-store
branch
from
07508b7 to
a4a5472
Compare
keelerm84
commented
May 16, 2025
| @@ -300,6 +301,32 @@ func (s *Store) getActive() subsystems.ReadOnlyStore { | |||
| return s.active | |||
| } | |||
|
|
|||
| //nolint:revive // Implementation for ReadOnlyDataStore. | |||
| func (s *Store) Snapshot() ( | |||
There was a problem hiding this comment.
When the relay tries to grab information from the store to determine what it should play back, it needs to get all the store information along with the selector in consistent fashion. Doing so increases data consistency but also will make some implementation details easier in the relay which you will see in the related PR here.
| // | ||
| // This field is not stable, and not subject to any backwards compatibility guarantees or semantic versioning. | ||
| // It is not suitable for production usage. Do not use it. You have been warned. | ||
| type ReadOnlyDataStore interface { |
There was a problem hiding this comment.
This name is not ideal. I realize this. I would welcome suggestions but also I'm making it clear you shouldn't be doing anything with this unless you are us.
There was a problem hiding this comment.
I'd go with a part of the name that describes the snapshotable-ness / transactional-ness of the read.
tanderson-ld
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.