-
Notifications
You must be signed in to change notification settings - Fork 22
chore: adds LDTransactionalFeatureStore, LDTransactionalDataSourceUpdates, and FDv2 DataSource impls. #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@launchdarkly/js-sdk-common size report |
@launchdarkly/js-client-sdk size report |
@launchdarkly/js-client-sdk-common size report |
76369ec
to
eb45ed6
Compare
packages/shared/sdk-server/src/api/subsystems/LDFeatureStore.ts
Outdated
Show resolved
Hide resolved
packages/shared/sdk-server/src/api/subsystems/LDDataSourceUpdates.ts
Outdated
Show resolved
Hide resolved
…ates, and FDv2 DataSource impls.
e3f5ac5
to
b0d426c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concern that ordering is much more important now, so we may need to validate when callbacks can happen and when they can be applied.
In the old stuff you would have a stream and you know you will get puts and then later patches and the way the event source works we really aren't going to break that. Polling included the entire payload, so even http requests completing out of order wasn't a problem.
Now data could come from many sources that are less coordinated.
Requirements
This PR moves changes for FDv2 from the temporary holding branch to main. All picked code has been previously reviewed and was picked from the temporary holding branch using file pick commands.
Resolved conflicts with @abarker-launchdarkly's recent initMetadata changes. Please verify those conflict resolutions @abarker-launchdarkly .