Skip to content

chore: Use factories instead of classes. #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore: Use factories instead of classes. #844

wants to merge 4 commits into from

Conversation

kinyoklion
Copy link
Member

Doing some testing on size impact.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 23840 bytes
Size limit: 25000

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 15786 bytes
Size limit: 20000

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025 •
edited
Loading

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 20672 bytes
Size limit: 21000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kinyoklion