-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Add support for per-context summary events. #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d6b4b45
to
5eee3b3
Compare
@launchdarkly/js-client-sdk-common size report |
@launchdarkly/js-client-sdk size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON files intentionally do not have newlines at the end for test purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a local canonicalization implementation, but we use standardized test data. Our implementation handles cycles.
@launchdarkly/js-sdk-common size report |
@@ -41,4 +41,4 @@ jobs: | |||
target_file: 'packages/sdk/browser/dist/index.js' | |||
package_name: '@launchdarkly/js-client-sdk' | |||
pr_number: ${{ github.event.number }} | |||
size_limit: 21000 | |||
size_limit: 25000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both this PR and the client-side identify PR need a little breathing room. This PR exceeded the limit by 174 bytes.
Adds support for per-context summary events. Per-context summary events allow for enhanced analytics to know which contexts evaluate which flags, even when those flags are not part of an experiment.