Skip to content

feat(components): Set select and combobox popover container width to be the width of the trigger #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cmaija
Copy link
Contributor

@cmaija cmaija commented May 14, 2025

Summary

This PR updates the popover so that it has a width of its trigger, which was the result of a conversation in slack

Screenshots (if appropriate):

before:
Screenshot 2025-05-14 at 2 10 53 PM

after:
Screenshot 2025-05-14 at 2 10 32 PM

Testing approaches

  • visual check in storybook

Copy link

changeset-bot bot commented May 14, 2025

🦋 Changeset detected

Latest commit: 48b76a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@launchpad-ui/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented May 14, 2025

npm i https://pkg.pr.new/@launchpad-ui/components@1669
npm i https://pkg.pr.new/@launchpad-ui/icons@1669
npm i https://pkg.pr.new/@launchpad-ui/tokens@1669

commit: 48b76a7

Copy link
Contributor

github-actions bot commented May 14, 2025

Size Change: +2 B (0%)

Total Size: 522 kB

Filename Size Change
packages/components/dist/style.css 7.29 kB +2 B (+0.03%)
ℹ️ View Unchanged
Filename Size
apps/vscode/dist/client.js 111 kB
apps/vscode/dist/server.js 258 kB
packages/box/dist/index.es.js 7.24 kB
packages/box/dist/index.js 7.82 kB
packages/box/dist/style.css 2.67 kB
packages/button/dist/index.es.js 1.95 kB
packages/button/dist/index.js 2.39 kB
packages/button/dist/style.css 3 kB
packages/components/dist/index.es.js 17.3 kB
packages/components/dist/index.js 18.2 kB
packages/core/dist/index.es.js 512 B
packages/core/dist/index.js 1.28 kB
packages/drawer/dist/index.es.js 1.76 kB
packages/drawer/dist/index.js 2.23 kB
packages/drawer/dist/style.css 497 B
packages/dropdown/dist/index.es.js 1.15 kB
packages/dropdown/dist/index.js 1.59 kB
packages/filter/dist/index.es.js 2.23 kB
packages/filter/dist/index.js 2.69 kB
packages/filter/dist/style.css 881 B
packages/focus-trap/dist/index.es.js 418 B
packages/focus-trap/dist/index.js 859 B
packages/form/dist/index.es.js 4.25 kB
packages/form/dist/index.js 4.74 kB
packages/form/dist/style.css 2.21 kB
packages/icons/dist/index.es.js 1.3 kB
packages/icons/dist/index.js 1.74 kB
packages/icons/dist/style.css 532 B
packages/menu/dist/index.es.js 3.68 kB
packages/menu/dist/index.js 4.17 kB
packages/menu/dist/style.css 872 B
packages/modal/dist/index.es.js 3.06 kB
packages/modal/dist/index.js 3.55 kB
packages/modal/dist/style.css 898 B
packages/navigation/dist/index.es.js 2.75 kB
packages/navigation/dist/index.js 3.22 kB
packages/navigation/dist/style.css 874 B
packages/overlay/dist/index.es.js 1.02 kB
packages/overlay/dist/index.js 1.43 kB
packages/popover/dist/index.es.js 3.06 kB
packages/popover/dist/index.js 3.48 kB
packages/popover/dist/style.css 529 B
packages/portal/dist/index.es.js 420 B
packages/portal/dist/index.js 842 B
packages/table/dist/index.es.js 1.01 kB
packages/table/dist/index.js 1.45 kB
packages/table/dist/style.css 700 B
packages/tokens/dist/fonts.css 183 B
packages/tokens/dist/index.css 1.47 kB
packages/tokens/dist/index.es.js 3.06 kB
packages/tokens/dist/index.js 3.1 kB
packages/tokens/dist/media-queries.css 113 B
packages/tokens/dist/themes.css 2.24 kB
packages/tooltip/dist/index.es.js 598 B
packages/tooltip/dist/index.js 1.03 kB
packages/tooltip/dist/style.css 337 B
packages/vars/dist/index.es.js 2.64 kB
packages/vars/dist/index.js 2.65 kB

compressed-size-action

@cmaija cmaija changed the title tryin something feat(components): Set select and combobox popover container width to be the width of the trigger May 14, 2025
@cmaija cmaija marked this pull request as ready for review May 14, 2025 22:02
@cmaija cmaija requested a review from a team as a code owner May 14, 2025 22:02
Copy link
Contributor

@apucacao apucacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmaija!

@apucacao
Copy link
Contributor

I'm going to merge this because there's another change we want to make sure goes out too.

@apucacao apucacao merged commit dff85bf into main May 16, 2025
14 checks passed
@apucacao apucacao deleted the canderson/feat/update-form-popovers-to-width-of-trigger branch May 16, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants