-
Notifications
You must be signed in to change notification settings - Fork 8
feat(components): Set select and combobox popover container width to be the width of the trigger #1669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): Set select and combobox popover container width to be the width of the trigger #1669
Conversation
🦋 Changeset detectedLatest commit: 48b76a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Size Change: +2 B (0%) Total Size: 522 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cmaija!
I'm going to merge this because there's another change we want to make sure goes out too. |
Summary
This PR updates the popover so that it has a
width
of its trigger, which was the result of a conversation in slackScreenshots (if appropriate):
before:

after:

Testing approaches