Skip to content

Fix: Remove empty sidebar entry caused by understanding-models.md #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

zihanKuang
Copy link
Contributor

@zihanKuang zihanKuang commented May 1, 2025

This PR removes the file:

content/en/kanvas/designer/understanding-models.md

The file had its front matter commented out, resulting in an empty title and causing an invisible menu item to appear under the Exploring Designer section in the sidebar.

Before

image
image

After

image
image

  • Yes, I signed my commits.

Signed-off-by: Zihan Kuang <[email protected]>
Copy link

netlify bot commented May 1, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit be45eb8
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/681345ce63184c0008d8087e
😎 Deploy Preview https://deploy-preview-515--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Is there an open issue to track the need for this page to be written, @zihanKuang

@zihanKuang
Copy link
Contributor Author

Hi @leecalcote,

I didn't create an issue for this, because the content intended for this page is already substantially covered in the Meshery documentation here: https://docs.meshery.io/concepts/logical/models.

Furthermore, this specific file had not been modified in over a year, and its conceptual focus was not well-aligned with its previous placement under the "Exploring Designer" section.🤔

So maybe we can directly remove this page.

@zihanKuang zihanKuang merged commit 497dff5 into layer5io:master May 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants