-
Notifications
You must be signed in to change notification settings - Fork 104
docs: improve Layers panel and comment features #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve Layers panel and comment features #519
Conversation
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Zihan Kuang <[email protected]>
@@ -10,7 +10,7 @@ aliases: | |||
- /meshmap/designer/comments | |||
--- | |||
|
|||
Kanvas's Designer offers enables you to place comments "inline" with your infrastructure as code. Use comments to offer feedback to team members, take detailed design notes, capture helpful tips for your team members, and include justification as to your infrastructure and application configuration decisions. Pay it forward to your future self by leaving historical record for reference later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This is a good way to orient the readers as to where is what we are talking about.
Please be cognizant of the fact that the green arrow and green outlined rectangle look very similar to the green outline and green arrow on the Comment component.
In the future, perhaps, choose a different color (e.g. red).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to place this comment on the other screenshot.
LGTM. This is well written, and easy to understand. The photoshop example is good, correct and on point. I tried to think of a similar example in Google docs, but nothing came to mind. |
screen-20250503-020536.mp4There is a responsiveness issue on this page, @zihanKuang |
Thanks for catching that! I’ve opened an issue to address the problem and will get it fixed. #522 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than merge conflict, we're good to go here. 👍
Signed-off-by: Lee Calcote <[email protected]>
Notes for Reviewers
This PR fixes #488 #498
/kanvas/advanced/performance
doc for better readability and user flow