refactor: youtube shortcode for custom styling , video fromatter to use camelCase consistently #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vishalvivekm <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vishalvivekm
commented
May 6, 2025
content/en/videos/getting-started/comments/design-reviews-full.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
vishalvivekm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR:
video_idtovideoId(following camelCase)youtubeshortcode for better styling control. It results in removal of the existing style from the<iframe>and its wrapping<div>element. So those default styles +margin: 2rem 0is added too.Signed commits