Skip to content

Commit 2f5a2d9

Browse files
eli-schwartzclefebvre
authored andcommitted
Retire outdated bluetooth code. (#7482)
- HAVE_BLUETOOTH is never used after it is defined in js/mis/config.js.in - pkg-config checks for applet_libdir fail since GNOME/gnome-bluetooth@a6cb98e gnome-bluetooth only supports being called from the system girepository - BLUEBERRY_LIBS are not actually linked into the final binaries, since they aren't included anywhere and no code calls functions from them. - Everything seems to be moved over to blueberry anyway.
1 parent 2ed853c commit 2f5a2d9

File tree

7 files changed

+3
-35
lines changed

7 files changed

+3
-35
lines changed

configure.ac

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -103,20 +103,6 @@ PKG_CHECK_MODULES(GDMUSER, dbus-glib-1 gtk+-3.0)
103103
PKG_CHECK_MODULES(TRAY, clutter-1.0 gtk+-3.0)
104104
PKG_CHECK_MODULES(DESKTOP_SCHEMAS, cinnamon-desktop >= 2.4.0)
105105

106-
AC_MSG_CHECKING([for bluetooth support])
107-
PKG_CHECK_EXISTS([gnome-bluetooth-1.0 >= 3.1.0],
108-
[BLUETOOTH_DIR=`$PKG_CONFIG --variable=applet_libdir gnome-bluetooth-1.0`
109-
BLUETOOTH_LIBS=`$PKG_CONFIG --variable=applet_libs gnome-bluetooth-1.0`
110-
AC_SUBST([BLUETOOTH_LIBS],["$BLUETOOTH_LIBS"])
111-
AC_SUBST([BLUETOOTH_DIR],["$BLUETOOTH_DIR"])
112-
AC_DEFINE_UNQUOTED([BLUETOOTH_DIR],["$BLUETOOTH_DIR"],[Path to installed GnomeBluetooth typelib and library])
113-
AC_DEFINE([HAVE_BLUETOOTH],[1],[Define if you have libgnome-bluetooth-applet])
114-
AC_SUBST([HAVE_BLUETOOTH],[1])
115-
AC_MSG_RESULT([yes])],
116-
[AC_DEFINE([HAVE_BLUETOOTH],[0])
117-
AC_SUBST([HAVE_BLUETOOTH],[0])
118-
AC_MSG_RESULT([no])])
119-
120106
MUFFIN_GIR_DIR=`$PKG_CONFIG --variable=girdir libmuffin`
121107
MUFFIN_TYPELIB_DIR=`$PKG_CONFIG --variable=typelibdir libmuffin`
122108
AC_SUBST(MUFFIN_GIR_DIR)

debian/control

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,12 @@ Build-Depends: debhelper (>= 9),
1212
gvfs-backends,
1313
gobject-introspection (>= 0.9.2),
1414
gir1.2-json-1.0,
15-
gnome-bluetooth (>= 3.1.0),
1615
gnome-common,
1716
libcinnamon-desktop-dev (>= 3.5.0),
1817
libcroco3-dev (>= 0.6.2),
1918
libdbus-glib-1-dev,
2019
libgirepository1.0-dev (>= 0.9.2),
2120
libglib2.0-dev (>= 2.37.3),
22-
libgnome-bluetooth-dev (>= 3.1.0),
2321
libcinnamon-menu-3-dev,
2422
libgstreamer1.0-dev,
2523
libgtk-3-dev (>= 3.9.12),
@@ -68,7 +66,6 @@ Depends: cinnamon-common (= ${source:Version}),
6866
gir1.2-accountsservice-1.0,
6967
gir1.2-cinnamondesktop-3.0 (>= 3.5.0),
7068
gir1.2-gkbd-3.0,
71-
gir1.2-gnomebluetooth-1.0,
7269
gir1.2-keybinder-3.0,
7370
gir1.2-networkmanager-1.0,
7471
gir1.2-polkit-1.0,

debian/shlibs.local

Lines changed: 0 additions & 1 deletion
This file was deleted.

js/misc/config.js.in

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,5 @@ var PACKAGE_NAME = '@PACKAGE_NAME@';
66
var PACKAGE_VERSION = '@PACKAGE_VERSION@';
77
/* The version of GJS we're linking to */
88
var GJS_VERSION = '@GJS_VERSION@';
9-
/* 1 if gnome-bluetooth is available, 0 otherwise */
10-
var HAVE_BLUETOOTH = @HAVE_BLUETOOTH@;
119
/* The system TLS CA list */
1210
var CINNAMON_SYSTEM_CA_FILE = '@CINNAMON_SYSTEM_CA_FILE@';

src/Makefile.am

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
NULL =
1+
NULL =
22
BUILT_SOURCES =
33
CLEANFILES =
44
EXTRA_DIST =
@@ -215,7 +215,6 @@ libcinnamon_la_LDFLAGS = $(WARN_LDFLAGS) -avoid-version
215215
libcinnamon_la_LIBADD = \
216216
-lm \
217217
$(CINNAMON_LIBS) \
218-
$(BLUETOOTH_LIBS) \
219218
libst-1.0.la \
220219
libtray.la \
221220
$(NULL)
@@ -228,7 +227,7 @@ Cinnamon_0_1_gir_CFLAGS = $(libcinnamon_la_CPPFLAGS) -I $(srcdir)
228227
Cinnamon_0_1_gir_LIBS = libcinnamon.la
229228
Cinnamon_0_1_gir_FILES = $(libcinnamon_la_gir_sources)
230229
Cinnamon_0_1_gir_SCANNERFLAGS = $(WARN_SCANNERFLAGS) --include-uninstalled=$(builddir)/St-1.0.gir \
231-
--add-include-path=$(MUFFIN_GIR_DIR) $(if $(BLUETOOTH_DIR),-L $(BLUETOOTH_DIR),)
230+
--add-include-path=$(MUFFIN_GIR_DIR)
232231
INTROSPECTION_GIRS += Cinnamon-0.1.gir
233232
CLEANFILES += Cinnamon-0.1.gir
234233

src/main.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ center_pointer_on_screen ()
249249
Display *dpy;
250250
Window root_window;
251251
Screen *screen;
252-
252+
253253
dpy = XOpenDisplay(0);
254254
root_window = XRootWindow(dpy, 0);
255255
XSelectInput(dpy, root_window, KeyReleaseMask);
@@ -310,9 +310,6 @@ main (int argc, char **argv)
310310
cinnamon_perf_log_init ();
311311

312312
g_irepository_prepend_search_path (CINNAMON_PKGLIBDIR);
313-
#if HAVE_BLUETOOTH
314-
g_irepository_prepend_search_path (BLUETOOTH_DIR);
315-
#endif
316313

317314
/* Disable debug spew from various libraries */
318315
g_log_set_handler ("Cvc", G_LOG_LEVEL_DEBUG,

src/run-js-test.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -129,14 +129,6 @@ main(int argc, char **argv)
129129
clutter_stage_set_title (CLUTTER_STAGE (stage), title);
130130
g_free (title);
131131

132-
#if HAVE_BLUETOOTH
133-
/* The module imports are all so intertwined that if the test
134-
* imports anything in js/ui, it will probably eventually end up
135-
* pulling in ui/status/bluetooth.js. So we need this.
136-
*/
137-
g_irepository_prepend_search_path (BLUETOOTH_DIR);
138-
#endif
139-
140132
/* evaluate the script */
141133
error = NULL;
142134
if (!gjs_context_eval (js_context, script, len,

0 commit comments

Comments
 (0)