Retire outdated bluetooth code. #7482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HAVE_BLUETOOTH is never used after it is defined in js/mis/config.js.in - pkg-config checks for applet_libdir fail since GNOME/gnome-bluetooth@a6cb98e gnome-bluetooth only supports being called from the system girepository - BLUEBERRY_LIBS are not actually linked into the final binaries, since they aren't included anywhere and no code calls functions from them. - Everything seems to be moved over to blueberry anyway.
|
Thanks! I initially noticed when one of my users asked me to remove the gnome-bluetooth dependency, since "it works if I manually force-remove it". So I went looking to see what uses it and if it is safe to move to optional dependencies... but then said "hey, this should be removed altogether". 😄 (I've been looking at pruning outdated dependencies from the Arch packaging, but didn't look much further than "oh, this is asked for in configure.ac".) |
Curly060
pushed a commit
to Curly060/Cinnamon
that referenced
this pull request
Jan 2, 2019
- HAVE_BLUETOOTH is never used after it is defined in js/mis/config.js.in - pkg-config checks for applet_libdir fail since GNOME/gnome-bluetooth@a6cb98e gnome-bluetooth only supports being called from the system girepository - BLUEBERRY_LIBS are not actually linked into the final binaries, since they aren't included anywhere and no code calls functions from them. - Everything seems to be moved over to blueberry anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gnome-bluetooth only supports being called from the system girepository
they aren't included anywhere and no code calls functions from them.