fix: workaround hardcoded dreamshaper changes

[vcashwin]

PR Type

Bug fix, Enhancement

---

Description

• Add useSearchParams in useStreamUpdates hook

• Only set prompts for Dreamshaper pipelines

• Remove always-on prompt slot creation

• Document current workaround via TODO comment

---

Changes walkthrough 📝

	Relevant files
Enhancement	useDreamshaper.tsx Conditional Dreamshaper prompt injection                                  apps/app/hooks/useDreamshaper.tsx Imported useSearchParams for query access Added isDreamshaper conditional around prompt injection Removed unconditional prompt slot creation Inserted TODO comment about hack +15/-7

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
pipelines-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2025 9:19am

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Missing Callback Dependency The searchParams value is used inside handleStreamUpdate but isn't included in the useCallback dependency array, which may lead to stale references. Add searchParams to the dependencies. const searchParams = useSearchParams(); const handleStreamUpdate = useCallback( Hardcoded Prompt Slot The prompt slot ID "5" is hardcoded in multiple places. Consider extracting it into a named constant or deriving it from the pipeline configuration to improve maintainability. if (!updatedInputValues.prompt["5"]) { updatedInputValues.prompt["5"] = { inputs: {} }; } if (!updatedInputValues.prompt["5"].inputs) { updatedInputValues.prompt["5"].inputs = {}; } updatedInputValues.prompt["5"].inputs.text = cleanedPrompt; } Conditional Logic Clarity The condition searchParams.get("isDreamshaper") !== "false" may be confusing and could result in unintended behavior if the parameter is omitted. Consider using an explicit check like === "true" or a clearer boolean flag. if (searchParams.get("isDreamshaper") !== "false") {

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Clear stale prompt text Add an else branch to clear or delete text on prompt["5"].inputs when isDreamshaper is "false", preventing stale prompt data from leaking into non-Dreamshaper pipelines. apps/app/hooks/useDreamshaper.tsx [470-479] if (searchParams.get("isDreamshaper") !== "false") { if (!updatedInputValues.prompt["5"]) { updatedInputValues.prompt["5"] = { inputs: {} }; } if (!updatedInputValues.prompt["5"].inputs) { updatedInputValues.prompt["5"].inputs = {}; } updatedInputValues.prompt["5"].inputs.text = cleanedPrompt; +} else { + if (updatedInputValues.prompt["5"]?.inputs?.text) { + delete updatedInputValues.prompt["5"].inputs.text; + } } Suggestion importance[1-10]: 7 __ Why: Adding an else branch to remove stale text prevents incorrect prompt data in non-Dreamshaper cases and improves data integrity.	Medium
General	Use nullish coalescing Simplify nested existence checks by using nullish coalescing to initialize the objects in a more concise and readable way. apps/app/hooks/useDreamshaper.tsx [471-476] -if (!updatedInputValues.prompt["5"]) { - updatedInputValues.prompt["5"] = { inputs: {} }; -} -if (!updatedInputValues.prompt["5"].inputs) { - updatedInputValues.prompt["5"].inputs = {}; -} +updatedInputValues.prompt["5"] = updatedInputValues.prompt["5"] ?? { inputs: {} }; +updatedInputValues.prompt["5"].inputs = updatedInputValues.prompt["5"].inputs ?? {}; Suggestion importance[1-10]: 5 __ Why: Replacing multiple existence checks with nullish coalescing makes the code more concise and readable with minimal functional change.	Low