-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[TextAPI] Track RPaths in the order its provided via command line. #131665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RPaths are basically search paths for how to load dependent libraries. The order they appear is the order the linker will search, we should preserve that order in tbd files. * Additionally add this level of detection to llvm-readtapi. resolves: rdar://145603347
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test that verifies the rpaths order is preserved?
Yes, in |
…lvm#131665) RPaths are basically search paths for how to load dependent libraries. The order they appear is the order the linker will search, we should preserve that order in tbd files. * Additionally add this level of detection to llvm-readtapi. resolves: rdar://145603347 (cherry picked from commit 4e4e4a1)
…lvm#131665) RPaths are basically search paths for how to load dependent libraries. The order they appear is the order the linker will search, we should preserve that order in tbd files. * Additionally add this level of detection to llvm-readtapi. resolves: rdar://145603347 (cherry picked from commit 4e4e4a1)
It looks like this is causing failures on the reverse-iteration buildbot: https://lab.llvm.org/buildbot/#/builders/110/builds/4558 . (https://lab.llvm.org/buildbot/#/builders/110/builds/5464 is a more recent build with logs, if you need.) |
thank you for reporting, I'm able to reproduce & will post a fix shortly |
@efriedma-quic Sorry, this took me a bit longer than I expected (got busy with other tasks), but a resolution is posted in #139087 |
RPaths are basically search paths for how to load dependent libraries. The order they appear is the order the linker will search, we should preserve that order in tbd files.
resolves: rdar://145603347