Skip to content

[TextAPI] Track RPaths in the order its provided via command line. #131665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

cyndyishida
Copy link
Member

RPaths are basically search paths for how to load dependent libraries. The order they appear is the order the linker will search, we should preserve that order in tbd files.

  • Additionally add this level of detection to llvm-readtapi.

resolves: rdar://145603347

RPaths are basically search paths for how to load dependent libraries.
The order they appear is the order the linker will search, we should
preserve that order in tbd files.

* Additionally add this level of detection to llvm-readtapi.

resolves: rdar://145603347
@cyndyishida cyndyishida requested a review from zixu-w March 17, 2025 19:44
Copy link
Member

@zixu-w zixu-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that verifies the rpaths order is preserved?

@cyndyishida
Copy link
Member Author

Is there a test that verifies the rpaths order is preserved?

Yes, in clang-installapi's rpath.test the llvm-readtapi change validates that the order.

@cyndyishida cyndyishida merged commit 4e4e4a1 into llvm:main Mar 19, 2025
12 checks passed
@cyndyishida cyndyishida deleted the eng/PR-145603347 branch March 19, 2025 05:12
cyndyishida added a commit to cyndyishida/llvm-project that referenced this pull request Mar 19, 2025
…lvm#131665)

RPaths are basically search paths for how to load dependent libraries.
The order they appear is the order the linker will search, we should
preserve that order in tbd files.

* Additionally add this level of detection to llvm-readtapi.

resolves: rdar://145603347
(cherry picked from commit 4e4e4a1)
cyndyishida added a commit to swiftlang/llvm-project that referenced this pull request Mar 20, 2025
…lvm#131665)

RPaths are basically search paths for how to load dependent libraries.
The order they appear is the order the linker will search, we should
preserve that order in tbd files.

* Additionally add this level of detection to llvm-readtapi.

resolves: rdar://145603347
(cherry picked from commit 4e4e4a1)
@efriedma-quic
Copy link
Collaborator

It looks like this is causing failures on the reverse-iteration buildbot: https://lab.llvm.org/buildbot/#/builders/110/builds/4558 . (https://lab.llvm.org/buildbot/#/builders/110/builds/5464 is a more recent build with logs, if you need.)

@cyndyishida
Copy link
Member Author

It looks like this is causing failures on the reverse-iteration buildbot: https://lab.llvm.org/buildbot/#/builders/110/builds/4558 . (https://lab.llvm.org/buildbot/#/builders/110/builds/5464 is a more recent build with logs, if you need.)

thank you for reporting, I'm able to reproduce & will post a fix shortly

@cyndyishida
Copy link
Member Author

It looks like this is causing failures on the reverse-iteration buildbot:

@efriedma-quic Sorry, this took me a bit longer than I expected (got busy with other tasks), but a resolution is posted in #139087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants