Skip to content

LLVM symbolizer gsym support #134847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 12, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
if/else formatting
  • Loading branch information
sfc-gh-mkwiczala committed May 7, 2025
commit 9f3bf6696d245d2c900ab9ac507a0dbc8f3f465a
13 changes: 5 additions & 8 deletions llvm/lib/DebugInfo/GSYM/GsymDIContext.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,11 @@ GsymDIContext::getLineInfoForAddress(object::SectionedAddress Address,
// No debug info for this, we just had a symbol from the symbol table.

// FIXME Demangle in case of DINameKind::ShortName
if (Specifier.FNKind != DINameKind::None) {
if (Specifier.FNKind != DINameKind::None)
LineInfo.FunctionName = Result.FuncName.str();
}
} else {
if (!fillLineInfoFromLocation(Result.Locations.front(), Specifier,
LineInfo))
return {};
}
} else if (!fillLineInfoFromLocation(Result.Locations.front(), Specifier,
LineInfo))
return {};

LineInfo.StartAddress = Result.FuncRange.start();

Expand Down Expand Up @@ -165,5 +162,5 @@ std::vector<DILocal>
GsymDIContext::getLocalsForAddress(object::SectionedAddress Address) {
// We can't implement this, there's no such information in the GSYM file.

return std::vector<DILocal>();
return {};
}