[OpenMP] Fix __builtin_return_address calls for SPARC #138520
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`libomp` uses `__builtin_return_address` in two places. However, on some targets those calls need to wrapped in `___builtin_extract_return_addr` to get at the actual return address. SPARC is among those targets and the only one where `clang` actually implements this, cf. [[clang][Sparc] Fix __builtin_extract_return_addr etc.](https://reviews.llvm.org/D91607). On other targets, this is a no-op. However, there are more targets that have the same issue and `gcc`, unlike `clang`, correctly implements it, so there might be issues when building `libomp` with `gcc`. This patch adds the necessary calls. Tested on `sparcv9-sun-solaris2.11`, `sparc64-unknown-linux-gnu`, `amd64-pc-solaris2.11`, and `x86_64-pc-linux-gnu`.
|
cc @MaskRay |
|
It occured to me that I should refer to the patch where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libompuses__builtin_return_addressin two places. However, on some targets those calls need to wrapped in___builtin_extract_return_addrto get at the actual return address. SPARC is among those targets and the only one whereclangactually implements this, cf. [clang][Sparc] Fix __builtin_extract_return_addr etc..compiler-rtneeded the same adjustment, cf. [sanitizer_common][test] Enable tests on SPARC. On other targets, this is a no-op. However, there are more targets that have the same issue andgcc, unlikeclang, correctly implements it, so there might be issues when buildinglibompwithgcc.This patch adds the necessary calls.
Tested on
sparcv9-sun-solaris2.11,sparc64-unknown-linux-gnu,amd64-pc-solaris2.11, andx86_64-pc-linux-gnu.