Skip to content

[CIR] Remove implicit options from tablegen files #138860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

xlauko
Copy link
Contributor

@xlauko xlauko commented May 7, 2025

This mirrors incubator changes from llvm/clangir#1602

@xlauko
Copy link
Contributor Author

xlauko commented May 7, 2025

@xlauko xlauko marked this pull request as ready for review May 7, 2025 12:42
@xlauko xlauko requested review from lanza and bcardosolopes as code owners May 7, 2025 12:42
@llvmbot llvmbot added clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project labels May 7, 2025
@llvmbot
Copy link
Member

llvmbot commented May 7, 2025

@llvm/pr-subscribers-clangir

@llvm/pr-subscribers-clang

Author: Henrich Lauko (xlauko)

Changes

This mirrors incubator changes from llvm/clangir#1602


Full diff: https://github.com/llvm/llvm-project/pull/138860.diff

1 Files Affected:

  • (modified) clang/include/clang/CIR/Dialect/IR/CIROps.td (-9)
diff --git a/clang/include/clang/CIR/Dialect/IR/CIROps.td b/clang/include/clang/CIR/Dialect/IR/CIROps.td
index 422c89c4f9391..9ff58752511f2 100644
--- a/clang/include/clang/CIR/Dialect/IR/CIROps.td
+++ b/clang/include/clang/CIR/Dialect/IR/CIROps.td
@@ -384,8 +384,6 @@ def AllocaOp : CIR_Op<"alloca", [
     `]`
     ($annotations^)? attr-dict
   }];
-
-  let hasVerifier = 0;
 }
 
 //===----------------------------------------------------------------------===//
@@ -1512,9 +1510,6 @@ def TernaryOp : CIR_Op<"ternary",
       >
   ];
 
-  // All constraints already verified elsewhere.
-  let hasVerifier = 0;
-
   let assemblyFormat = [{
     `(` $cond `,`
       `true` $trueRegion `,`
@@ -1652,9 +1647,6 @@ def GetGlobalOp : CIR_Op<"get_global",
   let assemblyFormat = [{
     $name `:` qualified(type($addr)) attr-dict
   }];
-
-  // `GetGlobalOp` is fully verified by its traits.
-  let hasVerifier = 0;
 }
 
 //===----------------------------------------------------------------------===//
@@ -1837,7 +1829,6 @@ class CIR_CallOpBase<string mnemonic, list<Trait> extra_traits = []>
 
   let hasCustomAssemblyFormat = 1;
   let skipDefaultBuilders = 1;
-  let hasVerifier = 0;
 
   // TODO(cir): for now cir.call is just a tiny shell of what it will become.
   // More attributes, arguments, and properties will be added in the future as

@xlauko xlauko requested review from andykaylor and erichkeane May 7, 2025 12:47
Copy link
Contributor

@andykaylor andykaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

andykaylor

This comment was marked as duplicate.

@xlauko
Copy link
Contributor Author

xlauko commented May 7, 2025

Merge activity

  • May 7, 1:16 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 7, 1:24 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 7, 1:27 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 7, 1:30 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 7, 1:31 PM EDT: @xlauko merged this pull request with Graphite.

@xlauko xlauko force-pushed the users/xlauko/cir-void-pointer-constraints branch from f93f03a to 5ce38e9 Compare May 7, 2025 17:21
Base automatically changed from users/xlauko/cir-void-pointer-constraints to main May 7, 2025 17:23
@xlauko xlauko force-pushed the users/xlauko/cir-remove-redundant-lets branch 2 times, most recently from 5bce5b6 to 51d9e9f Compare May 7, 2025 17:26
@xlauko xlauko force-pushed the users/xlauko/cir-remove-redundant-lets branch from 51d9e9f to 78160fd Compare May 7, 2025 17:29
@xlauko xlauko merged commit f8afefa into main May 7, 2025
6 of 9 checks passed
@xlauko xlauko deleted the users/xlauko/cir-remove-redundant-lets branch May 7, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category ClangIR Anything related to the ClangIR project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants