-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[CIR] Remove implicit options from tablegen files #138860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
@llvm/pr-subscribers-clangir @llvm/pr-subscribers-clang Author: Henrich Lauko (xlauko) ChangesThis mirrors incubator changes from llvm/clangir#1602 Full diff: https://github.com/llvm/llvm-project/pull/138860.diff 1 Files Affected:
diff --git a/clang/include/clang/CIR/Dialect/IR/CIROps.td b/clang/include/clang/CIR/Dialect/IR/CIROps.td
index 422c89c4f9391..9ff58752511f2 100644
--- a/clang/include/clang/CIR/Dialect/IR/CIROps.td
+++ b/clang/include/clang/CIR/Dialect/IR/CIROps.td
@@ -384,8 +384,6 @@ def AllocaOp : CIR_Op<"alloca", [
`]`
($annotations^)? attr-dict
}];
-
- let hasVerifier = 0;
}
//===----------------------------------------------------------------------===//
@@ -1512,9 +1510,6 @@ def TernaryOp : CIR_Op<"ternary",
>
];
- // All constraints already verified elsewhere.
- let hasVerifier = 0;
-
let assemblyFormat = [{
`(` $cond `,`
`true` $trueRegion `,`
@@ -1652,9 +1647,6 @@ def GetGlobalOp : CIR_Op<"get_global",
let assemblyFormat = [{
$name `:` qualified(type($addr)) attr-dict
}];
-
- // `GetGlobalOp` is fully verified by its traits.
- let hasVerifier = 0;
}
//===----------------------------------------------------------------------===//
@@ -1837,7 +1829,6 @@ class CIR_CallOpBase<string mnemonic, list<Trait> extra_traits = []>
let hasCustomAssemblyFormat = 1;
let skipDefaultBuilders = 1;
- let hasVerifier = 0;
// TODO(cir): for now cir.call is just a tiny shell of what it will become.
// More attributes, arguments, and properties will be added in the future as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merge activity
|
f93f03a
to
5ce38e9
Compare
5bce5b6
to
51d9e9f
Compare
This mirrors incubator changes from llvm/clangir#1602
51d9e9f
to
78160fd
Compare
This mirrors incubator changes from llvm/clangir#1602