Skip to content

[compiler-rt] Correctly detect cross-compiling for adding flags #138868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaronpuchert
Copy link
Member

This started with "Android is always cross-compiled" in commit aa9d74c, and continued with individual architectures like ARM in 6759fd9. Later Apple was carved out in 8887c63. I think we should just use the variable provided by CMake instead.

This started with "Android is always cross-compiled" in commit
aa9d74c, and continued with individual
architectures like ARM in 6759fd9.
Later Apple was carved out in 8887c63.
I think we should just use the variable provided by CMake instead.
Copy link
Member

@petrhosek petrhosek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that CMAKE_CROSSCOMPILING has a slightly different semantics, specifically it's TRUE whenever CMAKE_SYSTEM_NAME was set manually. I'd prefer using CMAKE_CROSSCOMPILING but it may be a potentially breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants