Skip to content

Propose new ClangIR Maintainers #138870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025
Merged

Conversation

erichkeane
Copy link
Collaborator

While I don't propose any change to the process we've been using for ClangIR contributions, it is important that we have maintainers listed so that folks have a good point of contact for the project in the upstream.

While I don't propose any change to the process we've been using for
ClangIR contributions, it is important that we have maintainers listed
so that folks have a good point of contact for the project in the
upstream.
@llvmbot llvmbot added the clang Clang issues not falling into any other category label May 7, 2025
@llvmbot
Copy link
Member

llvmbot commented May 7, 2025

@llvm/pr-subscribers-clang

Author: Erich Keane (erichkeane)

Changes

While I don't propose any change to the process we've been using for ClangIR contributions, it is important that we have maintainers listed so that folks have a good point of contact for the project in the upstream.


Full diff: https://github.com/llvm/llvm-project/pull/138870.diff

1 Files Affected:

  • (modified) clang/Maintainers.rst (+8)
diff --git a/clang/Maintainers.rst b/clang/Maintainers.rst
index dfe86a0773c16..0e6bdad3a8579 100644
--- a/clang/Maintainers.rst
+++ b/clang/Maintainers.rst
@@ -51,6 +51,14 @@ Clang LLVM IR generation
 | Anton Korobeynikov
 | anton\@korobeynikov.info (email), asl (Phabricator), asl (GitHub)
 
+Clang MLIR generation
+~~~~~~~~~~~~~~~~~~~~~
+| Andy Kaylor
+| akaylor\@nvidia.com (email), AndyKaylor (Discord), AndyKaylor (GitHub)
+
+| Bruno Cardoso Lopes
+| sonicsprawl (Discord), bcardosolopes (GitHub)
+
 
 Analysis & CFG
 ~~~~~~~~~~~~~~

Copy link
Collaborator

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for proposing this! I think both @andykaylor and @bcardosolopes would be excellent maintainers, so I approve so long as they're willing.

Copy link
Contributor

@cor3ntin cor3ntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Bruno and Andy have been involved with CIR for a while, it makes perfect sense!

@erichkeane
Copy link
Collaborator Author

Note per our maintainership rules, we need @andykaylor and @bcardosolopes to approve this as well to acknowledge the added responsibility.

@lanza
Copy link
Member

lanza commented May 7, 2025

Makes sense to me!

add bruno's email
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, applied a small change to add my email

@erichkeane erichkeane merged commit 3d71939 into llvm:main May 7, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants