-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Propose new ClangIR Maintainers #138870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose new ClangIR Maintainers #138870
Conversation
While I don't propose any change to the process we've been using for ClangIR contributions, it is important that we have maintainers listed so that folks have a good point of contact for the project in the upstream.
@llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) ChangesWhile I don't propose any change to the process we've been using for ClangIR contributions, it is important that we have maintainers listed so that folks have a good point of contact for the project in the upstream. Full diff: https://github.com/llvm/llvm-project/pull/138870.diff 1 Files Affected:
diff --git a/clang/Maintainers.rst b/clang/Maintainers.rst
index dfe86a0773c16..0e6bdad3a8579 100644
--- a/clang/Maintainers.rst
+++ b/clang/Maintainers.rst
@@ -51,6 +51,14 @@ Clang LLVM IR generation
| Anton Korobeynikov
| anton\@korobeynikov.info (email), asl (Phabricator), asl (GitHub)
+Clang MLIR generation
+~~~~~~~~~~~~~~~~~~~~~
+| Andy Kaylor
+| akaylor\@nvidia.com (email), AndyKaylor (Discord), AndyKaylor (GitHub)
+
+| Bruno Cardoso Lopes
+| sonicsprawl (Discord), bcardosolopes (GitHub)
+
Analysis & CFG
~~~~~~~~~~~~~~
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for proposing this! I think both @andykaylor and @bcardosolopes would be excellent maintainers, so I approve so long as they're willing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both Bruno and Andy have been involved with CIR for a while, it makes perfect sense!
Note per our maintainership rules, we need @andykaylor and @bcardosolopes to approve this as well to acknowledge the added responsibility. |
Makes sense to me! |
add bruno's email
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, applied a small change to add my email
While I don't propose any change to the process we've been using for ClangIR contributions, it is important that we have maintainers listed so that folks have a good point of contact for the project in the upstream.