Skip to content

[HLSL] Implicit resource binding for cbuffers #139022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
May 16, 2025
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
d5685ec
[HLSL] Implement DXILResourceBindingAnalysis
hekota Apr 24, 2025
d8a4a3f
Rename DXILResourceBindingsInfo to DXILResourceBindingInfo
hekota Apr 25, 2025
d79900c
Merge branch 'main' of https://github.com/llvm/llvm-project into reso…
hekota Apr 25, 2025
c718763
Add wrapper pass
hekota Apr 26, 2025
9a70f06
update signature
hekota Apr 28, 2025
bca1bf3
code review feedback - rename flags, remove unnecessary functions, do…
hekota Apr 30, 2025
f58e2d5
[HLSL] Implementation of DXILResourceImplicitBinding pass
hekota Apr 30, 2025
b65d3bc
fix bug & update tests
hekota May 1, 2025
075e27e
Merge branch 'main' of https://github.com/llvm/llvm-project into reso…
hekota May 2, 2025
2f0aba1
Remove extra new line
hekota May 5, 2025
79c2e7b
Merge branch 'main' of https://github.com/llvm/llvm-project into impl…
hekota May 6, 2025
e9747e5
Merge branch 'main' of https://github.com/llvm/llvm-project into reso…
hekota May 6, 2025
da838a9
Merge branch 'users/hekota/pr137258-resource-binding-analysis' of htt…
hekota May 6, 2025
dfce6ce
[HLSL] Add resource constructor with implicit binding for global reso…
hekota May 7, 2025
8194951
[HLSL] Implicit binding for cbuffers
hekota May 8, 2025
bcf27e9
Handle space-only implicit binding
hekota May 8, 2025
1f997d8
clang-format
hekota May 8, 2025
8a27708
code review feedback - use std::optional, renames
hekota May 9, 2025
bc93994
Merge branch 'main' of https://github.com/llvm/llvm-project into impl…
hekota May 9, 2025
8142713
Merge branch 'users/hekota/pr138043-implicit-binding-pass' of https:/…
hekota May 9, 2025
9eab67d
Merge branch 'users/hekota/pr138976-implicit-binding-constructor' of …
hekota May 9, 2025
4a3e4c5
revert changes to StructuredBuffers-methods-ps.hlsl
hekota May 9, 2025
03da2d1
update comment
hekota May 9, 2025
f3d9605
fix merge
hekota May 9, 2025
d4a3bcd
rename vars
hekota May 12, 2025
fb3d516
Merge branch 'main' of https://github.com/llvm/llvm-project into impl…
hekota May 13, 2025
2ff496b
code review feedback - update comment, rename param
hekota May 14, 2025
e4369aa
Merge branch 'main' of https://github.com/llvm/llvm-project into impl…
hekota May 14, 2025
cecd1e4
simplify constructor tests
hekota May 14, 2025
cef2c3e
rename vars
hekota May 14, 2025
d82236d
Merge branch 'users/hekota/pr138976-implicit-binding-constructor' int…
hekota May 14, 2025
84d710d
Merge branch 'main' into implicit-binding-cbuffers
hekota May 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comment
  • Loading branch information
hekota committed May 9, 2025
commit 03da2d1955069590f81b554dd560099fcba2a41d
4 changes: 2 additions & 2 deletions clang/lib/Sema/SemaHLSL.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -561,8 +561,8 @@ void SemaHLSL::ActOnFinishBuffer(Decl *Dcl, SourceLocation RBrace) {
HLSLResourceBindingAttr *RBA = Dcl->getAttr<HLSLResourceBindingAttr>();
if (!RBA || RBA->isImplicit()) {
SemaRef.Diag(Dcl->getLocation(), diag::warn_hlsl_implicit_binding);
// Use HLSLResourceBindingAttr as a way to transfer implicit binding
// order_ID to codegen. If it does not exist, create an implicit one.
// Use HLSLResourceBindingAttr to transfer implicit binding order_ID
// to codegen. If it does not exist, create an implicit attribute.
uint32_t OrderID = getNextImplicitBindingOrderID();
if (RBA)
RBA->setImplicitBindingOrderID(OrderID);
Expand Down
Loading