[clang][dataflow] Add bugprone-dataflow-dead-code check #139068
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finds instances of always-true and always-false conditions in branch statements, a straightforward use case for the dataflow framework.
This check is a work in progress - the core of the check is simple, but there are too many false positives currently for the check to be usable.
More heuristics are needed to reduce the count of false positives.
Currently only assert-like statements are filtered out. More information on false-positive types are in the docs here:
https://github.com/Discookie/llvm-project/blob/dataflow-deadcode/clang-tools-extra/docs/clang-tidy/checks/bugprone/dataflow-dead-code.rst
Results on some open-source projects
Framework improvements needed for the check to be fully functional: