[llvm][docs] Small improvements to llvm-test-suite doc #139083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DavidSpickett
commented
May 8, 2025
•
DavidSpickett
commented
- Mention earlier that the C++ compiler will be inferred from the C compiler setting. It does say this later, but a mention earlier will save people (aka me) from wondering why we don't set CMAKE_CXX_COMPILER.
- Mention earlier the compile only TEST_SUITE_RUN_BENCHMARKS=OFF setting, as it's a common use case. We already say the consequences of doing that, but not actually how to enable it until later in the doc.
- Reorder that text to make more sense.
- Make it into a proper Sphinx note block.
* Mention earlier that the C++ compiler will be inferred from the C compiler setting. It does say this later, but a mention earlier will save people (aka me) from wondering why we don't set CMAKE_CXX_COMPILER. * Mention earlier the compile only TEST_SUITE_RUN_BENCHMARKS=OFF setting, as it's a common use case. We already say the consequences of doing that, but not actually how to enable it until later in the doc.
tarunprabhu
reviewed
May 8, 2025
DavidSpickett
changed the title
tarunprabhu
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.