Skip to content

[lldb][lldb-dap] Disable more tests on Windows #139251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

DavidSpickett
Copy link
Collaborator

@DavidSpickett DavidSpickett commented May 9, 2025

These are currently failing on Windows on Arm:
https://lab.llvm.org/buildbot/#/builders/141/builds/8556

********************
Unresolved Tests (1):
  lldb-api :: tools/lldb-dap/memory/TestDAP_memory.py
********************
Failed Tests (1):
  lldb-api :: tools/lldb-dap/variables/TestDAP_variables.py

These are currently failing on Windows on Arm:
https://lab.llvm.org/buildbot/#/builders/141/builds/8556

********************
Unresolved Tests (1):
  lldb-api :: tools/lldb-dap/memory/TestDAP_memory.py
********************
Failed Tests (1):
  lldb-api :: tools/lldb-dap/variables/TestDAP_variables.py
@llvmbot llvmbot added the lldb label May 9, 2025
@DavidSpickett DavidSpickett merged commit c64c64d into llvm:main May 9, 2025
8 of 11 checks passed
@llvmbot
Copy link
Member

llvmbot commented May 9, 2025

@llvm/pr-subscribers-lldb

Author: David Spickett (DavidSpickett)

Changes

These are currently failing on Windows on Arm:
https://lab.llvm.org/buildbot/#/builders/141/builds/8556

********************
Unresolved Tests (1):
  lldb-api :: tools/lldb-dap/memory/TestDAP_memory.py
********************
Failed Tests (1):
  lldb-api :: tools/lldb-dap/variables/TestDAP_variables.py

Full diff: https://github.com/llvm/llvm-project/pull/139251.diff

2 Files Affected:

  • (modified) lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py (+4)
  • (modified) lldb/test/API/tools/lldb-dap/variables/TestDAP_variables.py (+4)
diff --git a/lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py b/lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py
index ea43fccf016a7..74062f3ab2164 100644
--- a/lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py
+++ b/lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py
@@ -12,6 +12,7 @@
 
 
 class TestDAP_memory(lldbdap_testcase.DAPTestCaseBase):
+    @skipIfWindows
     def test_memory_refs_variables(self):
         """
         Tests memory references for evaluate
@@ -33,6 +34,7 @@ def test_memory_refs_variables(self):
         # Non-pointers should also have memory-references
         self.assertIn("memoryReference", locals["not_a_ptr"].keys())
 
+    @skipIfWindows
     def test_memory_refs_evaluate(self):
         """
         Tests memory references for evaluate
@@ -52,6 +54,7 @@ def test_memory_refs_evaluate(self):
             self.dap_server.request_evaluate("rawptr")["body"].keys(),
         )
 
+    @skipIfWindows
     def test_memory_refs_set_variable(self):
         """
         Tests memory references for `setVariable`
@@ -74,6 +77,7 @@ def test_memory_refs_set_variable(self):
             ].keys(),
         )
 
+    @skipIfWindows
     def test_readMemory(self):
         """
         Tests the 'readMemory' request
diff --git a/lldb/test/API/tools/lldb-dap/variables/TestDAP_variables.py b/lldb/test/API/tools/lldb-dap/variables/TestDAP_variables.py
index 3b45cdc245838..296e4911f4052 100644
--- a/lldb/test/API/tools/lldb-dap/variables/TestDAP_variables.py
+++ b/lldb/test/API/tools/lldb-dap/variables/TestDAP_variables.py
@@ -411,16 +411,19 @@ def do_test_scopes_variables_setVariable_evaluate(
 
         self.verify_variables(verify_locals, locals)
 
+    @skipIfWindows
     def test_scopes_variables_setVariable_evaluate(self):
         self.do_test_scopes_variables_setVariable_evaluate(
             enableAutoVariableSummaries=False
         )
 
+    @skipIfWindows
     def test_scopes_variables_setVariable_evaluate_with_descriptive_summaries(self):
         self.do_test_scopes_variables_setVariable_evaluate(
             enableAutoVariableSummaries=True
         )
 
+    @skipIfWindows
     def do_test_scopes_and_evaluate_expansion(self, enableAutoVariableSummaries: bool):
         """
         Tests the evaluated expression expands successfully after "scopes" packets
@@ -673,6 +676,7 @@ def do_test_indexedVariables(self, enableSyntheticChildDebugging: bool):
         ]["variables"]
         self.verify_variables(verify_children, children)
 
+    @skipIfWindows
     def test_return_variables(self):
         """
         Test the stepping out of a function with return value show the variable correctly.

@DavidSpickett DavidSpickett deleted the lldb-dap-skip branch May 9, 2025 12:19
@DavidSpickett
Copy link
Collaborator Author

@JDevlieghere FYI.

I realise this is not the most helpful or informative action to take, but Linaro folks will be busy with other things next week so I want this bot green again soon.

If you need us to investigate locally I can do that but it'll be the week of the 19th before I will have time to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants