Skip to content

[ORC] Fix the prototype of a C API function. #139259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

maleadt
Copy link
Contributor

@maleadt maleadt commented May 9, 2025

In 38d16f5, the TargetTriple argument was removed from the LLVMOrcCreateStaticLibrarySearchGeneratorForPath without updating the C API headers. This results in the function being exported without C linkage, making it impossible to use from C.

Before 38d16f5:

❯ objdump -t bisect/lib/libLLVMOrcJIT.so | grep LLVMOrcCreateStaticLibrarySearchGeneratorForPath 
00000000001502b0 g     F .text  000000000000021c              LLVMOrcCreateStaticLibrarySearchGeneratorForPath

After 38d16f5:

❯ objdump -t bisect/lib/libLLVMOrcJIT.so | grep LLVMOrcCreateStaticLibrarySearchGeneratorForPath 
000000000014ff30 g     F .text  00000000000000de              _Z48LLVMOrcCreateStaticLibrarySearchGeneratorForPathPP32LLVMOrcOpaqueDefinitionGeneratorP24LLVMOrcOpaqueObjectLayerPKc

cc @lhames

@lhames
Copy link
Contributor

lhames commented May 12, 2025

@llvm-ci please test

@lhames lhames merged commit 70a3a1b into llvm:main May 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants