Skip to content

[lldb] Remove redundant calls to std::unique_ptr<T>::get (NFC) #139395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kazutakahirata
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented May 10, 2025

@llvm/pr-subscribers-lldb

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/139395.diff

2 Files Affected:

  • (modified) lldb/source/API/SBSaveCoreOptions.cpp (+1-1)
  • (modified) lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h (+2-2)
diff --git a/lldb/source/API/SBSaveCoreOptions.cpp b/lldb/source/API/SBSaveCoreOptions.cpp
index e101f6a25783c..15584abaac013 100644
--- a/lldb/source/API/SBSaveCoreOptions.cpp
+++ b/lldb/source/API/SBSaveCoreOptions.cpp
@@ -129,5 +129,5 @@ uint64_t SBSaveCoreOptions::GetCurrentSizeInBytes(SBError &error) {
 }
 
 lldb_private::SaveCoreOptions &SBSaveCoreOptions::ref() const {
-  return *m_opaque_up.get();
+  return *m_opaque_up;
 }
diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
index d8d519693f102..ea763b94fcc75 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
+++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
@@ -344,7 +344,7 @@ class ClangExpressionDeclMap : public ClangASTSource {
 
   /// Activate parser-specific variables
   void EnableParserVars() {
-    if (!m_parser_vars.get())
+    if (!m_parser_vars)
       m_parser_vars = std::make_unique<ParserVars>();
   }
 
@@ -371,7 +371,7 @@ class ClangExpressionDeclMap : public ClangASTSource {
 
   /// Activate struct variables
   void EnableStructVars() {
-    if (!m_struct_vars.get())
+    if (!m_struct_vars)
       m_struct_vars.reset(new struct StructVars);
   }
 

@kazutakahirata kazutakahirata merged commit d151ad6 into llvm:main May 10, 2025
12 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_clang_tidy_readability_redundant_smartptr_get_lldb branch May 10, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants