[ObjCopy] Use StringRef::starts_with (NFC)

[kazutakahirata]

No description provided.

[llvmbot]

@llvm/pr-subscribers-llvm-binary-utilities

Author: Kazu Hirata (kazutakahirata)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/139408.diff

1 Files Affected:

• (modified) llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp (+1-2)

diff --git a/llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp b/llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp
index 935f89ad76440..f810bbf639300 100644
--- a/llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp
+++ b/llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp
@@ -352,8 +352,7 @@ static Error updateAndRemoveSymbols(const CommonConfig &Config,
       Sym.Name = std::string(I->getValue());
 
     if (!Config.SymbolsPrefixRemove.empty() && Sym.Type != STT_SECTION)
-      if (Sym.Name.compare(0, Config.SymbolsPrefixRemove.size(),
-                           Config.SymbolsPrefixRemove) == 0)
+      if (StringRef(Sym.Name).starts_with(Config.SymbolsPrefixRemove))
         Sym.Name = Sym.Name.substr(Config.SymbolsPrefixRemove.size());
 
     if (!Config.SymbolsPrefix.empty() && Sym.Type != STT_SECTION)

[MaskRay]

Can use consume_front

[kazutakahirata]

@MaskRay

Can use consume_front

Yes, I've thought about, but I wasn't sure if the use of a temporary variable is elegant. Thoughts?

      StringRef Tmp = Sym.Name;
      if (Tmp.consumeFront(Config.SymbolsPrefixRemove))
        Sym.Name = Tmp;