Skip to content

[AMDGPULowerBufferFatPointers] Handle ptrtoaddr by extending the offset #139413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: users/arichardson/spr/main.amdgpulowerbufferfatpointers-handle-ptrtoaddr-by-extending-the-offset
Choose a base branch
from
+26 −5
Open

[AMDGPULowerBufferFatPointers] Handle ptrtoaddr by extending the offset #139413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fe79dd8
[𝘀𝗽𝗿] initial version
arichardson May 10, 2025
a2dec95
remove fixme
arichardson May 10, 2025
e45ac7c
rebase
arichardson May 11, 2025
c9db137
rebase
arichardson Jun 11, 2025
d48e4ab
address review comment
arichardson Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions llvm/lib/Target/AMDGPU/AMDGPULowerBufferFatPointers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,6 +1360,7 @@ class SplitPtrStructs : public InstVisitor<SplitPtrStructs, PtrParts> {
PtrParts visitAtomicCmpXchgInst(AtomicCmpXchgInst &AI);
PtrParts visitGetElementPtrInst(GetElementPtrInst &GEP);

PtrParts visitPtrToAddrInst(PtrToAddrInst &PA);
PtrParts visitPtrToIntInst(PtrToIntInst &PI);
PtrParts visitIntToPtrInst(IntToPtrInst &IP);
PtrParts visitAddrSpaceCastInst(AddrSpaceCastInst &I);
Expand Down Expand Up @@ -1951,6 +1952,21 @@ PtrParts SplitPtrStructs::visitPtrToIntInst(PtrToIntInst &PI) {
return {nullptr, nullptr};
}

PtrParts SplitPtrStructs::visitPtrToAddrInst(PtrToAddrInst &PA) {
Value *Ptr = PA.getPointerOperand();
if (!isSplitFatPtr(Ptr->getType()))
return {nullptr, nullptr};
IRB.SetInsertPoint(&PA);

auto [Rsrc, Off] = getPtrParts(Ptr);
Value *Res = IRB.CreateIntCast(Off, PA.getType(), /*isSigned=*/false);
copyMetadata(Res, &PA);
Res->takeName(&PA);
SplitUsers.insert(&PA);
PA.replaceAllUsesWith(Res);
return {nullptr, nullptr};
}

PtrParts SplitPtrStructs::visitIntToPtrInst(IntToPtrInst &IP) {
if (!isSplitFatPtr(IP.getType()))
return {nullptr, nullptr};
Expand Down
15 changes: 10 additions & 5 deletions llvm/test/CodeGen/AMDGPU/lower-buffer-fat-pointers-pointer-ops.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,8 @@ define i32 @ptrtoint_offset(ptr addrspace(7) %ptr) {
define i32 @ptrtoaddr(ptr addrspace(7) %ptr) {
; CHECK-LABEL: define i32 @ptrtoaddr
; CHECK-SAME: ({ ptr addrspace(8), i32 } [[PTR:%.*]]) #[[ATTR0]] {
; CHECK-NEXT: [[RET:%.*]] = ptrtoaddr { ptr addrspace(8), i32 } [[PTR]] to i32
; CHECK-NEXT: [[PTR_RSRC:%.*]] = extractvalue { ptr addrspace(8), i32 } [[PTR]], 0
; CHECK-NEXT: [[RET:%.*]] = extractvalue { ptr addrspace(8), i32 } [[PTR]], 1
; CHECK-NEXT: ret i32 [[RET]]
;
%ret = ptrtoaddr ptr addrspace(7) %ptr to i32
Expand All @@ -268,19 +269,21 @@ define i32 @ptrtoaddr(ptr addrspace(7) %ptr) {
define <2 x i32> @ptrtoaddr_vec(<2 x ptr addrspace(7)> %ptr) {
; CHECK-LABEL: define <2 x i32> @ptrtoaddr_vec
; CHECK-SAME: ({ <2 x ptr addrspace(8)>, <2 x i32> } [[PTR:%.*]]) #[[ATTR0]] {
; CHECK-NEXT: [[RET:%.*]] = ptrtoaddr { <2 x ptr addrspace(8)>, <2 x i32> } [[PTR]] to <2 x i32>
; CHECK-NEXT: [[PTR_RSRC:%.*]] = extractvalue { <2 x ptr addrspace(8)>, <2 x i32> } [[PTR]], 0
; CHECK-NEXT: [[RET:%.*]] = extractvalue { <2 x ptr addrspace(8)>, <2 x i32> } [[PTR]], 1
; CHECK-NEXT: ret <2 x i32> [[RET]]
;
%ret = ptrtoaddr <2 x ptr addrspace(7)> %ptr to <2 x i32>
ret <2 x i32> %ret
}

;; Check that we extend the offset to i160 instead of reinterpreting all bits.
;; FIXME: this is not currently correct.
define i160 @ptrtoaddr_ext(ptr addrspace(7) %ptr) {
; CHECK-LABEL: define i160 @ptrtoaddr_ext
; CHECK-SAME: ({ ptr addrspace(8), i32 } [[PTR:%.*]]) #[[ATTR0]] {
; CHECK-NEXT: [[RET:%.*]] = ptrtoaddr { ptr addrspace(8), i32 } [[PTR]] to i160
; CHECK-NEXT: [[PTR_RSRC:%.*]] = extractvalue { ptr addrspace(8), i32 } [[PTR]], 0
; CHECK-NEXT: [[PTR_OFF:%.*]] = extractvalue { ptr addrspace(8), i32 } [[PTR]], 1
; CHECK-NEXT: [[RET:%.*]] = zext i32 [[PTR_OFF]] to i160
; CHECK-NEXT: ret i160 [[RET]]
;
%ret = ptrtoaddr ptr addrspace(7) %ptr to i160
Expand All @@ -290,7 +293,9 @@ define i160 @ptrtoaddr_ext(ptr addrspace(7) %ptr) {
define i16 @ptrtoaddr_trunc(ptr addrspace(7) %ptr) {
; CHECK-LABEL: define i16 @ptrtoaddr_trunc
; CHECK-SAME: ({ ptr addrspace(8), i32 } [[PTR:%.*]]) #[[ATTR0]] {
; CHECK-NEXT: [[RET:%.*]] = ptrtoaddr { ptr addrspace(8), i32 } [[PTR]] to i16
; CHECK-NEXT: [[PTR_RSRC:%.*]] = extractvalue { ptr addrspace(8), i32 } [[PTR]], 0
; CHECK-NEXT: [[PTR_OFF:%.*]] = extractvalue { ptr addrspace(8), i32 } [[PTR]], 1
; CHECK-NEXT: [[RET:%.*]] = trunc i32 [[PTR_OFF]] to i16
; CHECK-NEXT: ret i16 [[RET]]
;
%ret = ptrtoaddr ptr addrspace(7) %ptr to i16
Expand Down